Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angela Oh #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Angela Oh #16

wants to merge 1 commit into from

Conversation

AngelaOh
Copy link

No description provided.

CheezItMan
CheezItMan reviewed Sep 3, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, you didn't get every method implemented but the ones written work well. You hit the learning goals here!

lib/linked_list.rb
else # if deleting from somewhere in middle or end
until current.data == value
previous = current
current = current.next
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about if the value is not in the list. You could try to do .data on nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AngelaOh @CheezItMan